Conversation
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP URP SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Thanks for the change:
- I know that the inspector name is not from your PR, as you just move code arround. But if you could change it I will appreciate it
- I've kicked the find missing docs Yamato, just to see if there are methods that need the public API Docs
Edit: Missing Docs on the Core package:
[12:58:27.833 Information] Missing Doc on static System.Void UnityEditor.Rendering.CameraUI.PhysicalCamera::Drawer_PhysicalCamera_FocusDistance(UnityEditor.Rendering.ISerializedCamera, Editor)
Missing Doc on static System.Void UnityEditor.Rendering.CameraUI.PhysicalCamera::Drawer_PhysicalCamera_CameraBody_ISO(UnityEditor.Rendering.ISerializedCamera, Editor)
Missing Doc on static System.Void UnityEditor.Rendering.CameraUI.PhysicalCamera::Drawer_PhysicalCamera_CameraBody_ShutterSpeed(UnityEditor.Rendering.ISerializedCamera, Editor)
Missing Doc on static System.Void UnityEditor.Rendering.CameraUI.PhysicalCamera::Drawer_PhysicalCamera_Lens_Aperture(UnityEditor.Rendering.ISerializedCamera, Editor)
Missing Doc on static System.Void UnityEditor.Rendering.CameraUI.PhysicalCamera::Drawer_PhysicalCamera_ApertureShape(UnityEditor.Rendering.ISerializedCamera, Editor)
Missing Doc on UnityEditor.Rendering.CameraUI.PhysicalCamera.Styles.ISO
Missing Doc on UnityEditor.Rendering.CameraUI.PhysicalCamera.Styles.shutterSpeed
Missing Doc on UnityEditor.Rendering.CameraUI.PhysicalCamera.Styles.aperture
Missing Doc on UnityEditor.Rendering.CameraUI.PhysicalCamera.Styles.focusDistance
Missing Doc on UnityEditor.Rendering.CameraUI.PhysicalCamera.Styles.apertureShape
Missing Doc on UnityEditor.Rendering.CameraUI.PhysicalCamera.Styles.bladeCount
Missing Doc on UnityEditor.Rendering.CameraUI.PhysicalCamera.Styles.curvature
Missing Doc on UnityEditor.Rendering.CameraUI.PhysicalCamera.Styles.barrelClipping
Missing Doc on UnityEditor.Rendering.CameraUI.PhysicalCamera.Styles.anamorphism
com.unity.render-pipelines.core/Editor/Camera/CameraUI.PhysicalCamera.Drawers.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Editor/Camera/CameraUI.PhysicalCamera.Drawers.cs
Outdated
Show resolved
Hide resolved
...-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDAdditionalCameraData.Migration.cs
Show resolved
Hide resolved
...ity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDAdditionalCameraData.cs
Outdated
Show resolved
Hide resolved
...ity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDAdditionalCameraData.cs
Outdated
Show resolved
Hide resolved
| parameters.physicalCameraCurvature = camera.camera.curvature; | ||
| parameters.physicalCameraAnamorphism = camera.camera.anamorphism; | ||
| parameters.physicalCameraAperture = camera.camera.aperture; | ||
| parameters.physicalCameraBarrelClipping = camera.camera.barrelClipping; | ||
| parameters.physicalCameraBladeCount = camera.camera.bladeCount; |
There was a problem hiding this comment.
Maybe you could introduce a local variable, physicalCamera
…lCamera.Drawers.cs Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com>
…lCamera.Drawers.cs Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com>
…ine/Camera/HDAdditionalCameraData.Migration.cs Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com>
…ine/Camera/HDAdditionalCameraData.cs Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com>
…ine/Camera/HDAdditionalCameraData.cs Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com>
2 participants
One half of this PR:
https://ono.unity3d.com/unity/unity/pull-request/139252/_/graphics/update-physical-camera
Purpose of this PR
This PR migrates a number of settings from HDRP down into core unity camera class so they can be shared between URP and HDRP. The change includes data upgraders and updated UI that is shared between URP and HDRP.
Testing status
Covered via automated testing.
Comments to reviewers
Needs to be reviewed in conjunction with:
https://ono.unity3d.com/unity/unity/pull-request/139252/_/graphics/update-physical-camera